Skip to content

Revert "Cherry-pick #5029 #5096 #5097 #5099 #5108 #5113 #5114 #5115 #5116 #5118 #5126 #5128 #5130"#5135

Merged
ffjlabo merged 1 commit intorelease-v0.48.xfrom
revert-5132-cherry-pick-#5029-#5096-#5097-#5099-#5108-#5113-#5114-#5115-#5116-#5118-#5126-#5128-#5130-to-release-v0.48.x
Aug 15, 2024
Merged

Revert "Cherry-pick #5029 #5096 #5097 #5099 #5108 #5113 #5114 #5115 #5116 #5118 #5126 #5128 #5130"#5135
ffjlabo merged 1 commit intorelease-v0.48.xfrom
revert-5132-cherry-pick-#5029-#5096-#5097-#5099-#5108-#5113-#5114-#5115-#5116-#5118-#5126-#5128-#5130-to-release-v0.48.x

Conversation

@ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Aug 15, 2024

Reverts #5132

@ffjlabo
Revert "Cherry-pick #5029 #5096 #5097 #5099 #5108 #5113 #5114 #5115 #…
9ee9fe3 
…5116 #51…"

This reverts commit b1d9cd0.

Signed-off-by: Yoshiki Fujikane <40124947+ffjlabo@users.noreply.github.com>
@ffjlabo ffjlabo force-pushed the revert-5132-cherry-pick-#5029-#5096-#5097-#5099-#5108-#5113-#5114-#5115-#5116-#5118-#5126-#5128-#5130-to-release-v0.48.x branch from bccb7b1 to 9ee9fe3 Compare August 15, 2024 01:31
@ffjlabo
Copy link
Member Author

ffjlabo commented Aug 15, 2024 •
edited
Loading

I signed off with git commit -s --amend. Not affect the original commit.

@codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 22.52%. Comparing base (b1d9cd0) to head (9ee9fe3).
Report is 1 commits behind head on release-v0.48.x.

Files Patch % Lines
pkg/app/piped/cmd/piped/piped.go 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@                 Coverage Diff                 @@
##           release-v0.48.x    #5135      +/-   ##
===================================================
+ Coverage            22.49%   22.52%   +0.03%     
===================================================
  Files                  519      519              
  Lines                56955    56912      -43     
===================================================
+ Hits                 12812    12822      +10     
+ Misses               43115    43063      -52     
+ Partials              1028     1027       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo ffjlabo merged commit 49f7ec0 into release-v0.48.x Aug 15, 2024
@ffjlabo ffjlabo deleted the revert-5132-cherry-pick-#5029-#5096-#5097-#5099-#5108-#5113-#5114-#5115-#5116-#5118-#5126-#5128-#5130-to-release-v0.48.x branch August 15, 2024 02:03
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Merged
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 khanhtc1202 approved these changes

@t-kikuc t-kikuc t-kikuc approved these changes

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

@kentakozuka kentakozuka Awaiting requested review from kentakozuka kentakozuka is a code owner

@Warashi Warashi Awaiting requested review from Warashi Warashi is a code owner

Assignees

No one assigned

Labels

area/build area/go area/tool area/web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ffjlabo @khanhtc1202 @t-kikuc